Exercise side #20
Open
Exercise side #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pen-pals ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
8BitRobot
suggested changes
Mar 27, 2022
| <h1> Type the correct numbers into the blanks below! </h1> | ||
| <h1> A = (2,0) </h1> | ||
| <h1> B = (-2,0) </h1> | ||
| <h1> C = (-1,0) </h1> |
There was a problem hiding this comment.
A few small things:
- Given the layout of the text in the designs, it makes more sense in my opinion to have the actual "exercises," i.e. the problems they have to solve, in their own
div(perhaps with its own ID oflevel-exercise-promptsor similar?). This would allow you to add the additional spacing between the actual heading of the exercise (the main prompt at the top) and the questions without adding some arbitrary spacing between text items 1 and 2. In addition, it would make it easier to dynamically render exercises, for when we do that in the future. - Generally it's bad practice to overuse headings, especially the
h1element which is reserved for top-level headings and the like. I suggest instead that you useptags for all of these and style them as needed. - The letters A, B, and C should be italicized; I suggest wrapping them in a
spanelement and giving thespanthe appropriate styling for italics (I think it's something like "font-style: italic"?).
| } | ||
|
|
||
| button { | ||
| background-color: green; |
There was a problem hiding this comment.
Don't forget to use the correct shade of green that's in the colors.scss file! You can see an example of how to use variables from that file by looking at line 9 of this file. Just check the colors.scss file for the variable name and include it according to the syntax from line 9. Also, there's no need for a border on this button as it's all one color; the Figma doesn't include any border either.
| button { | ||
| background-color: green; | ||
| border: 1px solid #e1e4e8; | ||
| border-radius: 10px; |
There was a problem hiding this comment.
Similar to the comment on colors, this should be 12px, not 10px.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#4 added the level text to the Exercise Side