Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates react-scripts to v4, eslint to v7 #137

Merged
merged 2 commits into from
May 13, 2021
Merged

Conversation

mattxwang
Copy link
Member

@mattxwang mattxwang commented May 5, 2021

This PR does a couple of things:

Closes #136.

@mattxwang mattxwang requested a review from a team May 5, 2021 07:43
@mattxwang
Copy link
Member Author

mattxwang commented May 5, 2021

As a note, we're failing a CI error from an issue with sass not resolving images in the public loader. This is an open issue on the CRA repo, and I don't want to bundle the image into our stylesheet if possible.

facebook/create-react-app#10022

facebook/create-react-app#9937

Curious if other peeps have thoughts on this; there's no burning reason to switch over yet, though we'll have to deal with it soon.

FWIW, this is the problem line:

background-image: url(/images/about1.png);

Copy link
Member

@evanzhong evanzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the most part lgtm.

Things I note:

  • Merge conflict on package-lock.json is pretty gnarly, can just force push if you want as you listed in PR description.
  • Personally I'm not opposed to just bundling the image if it's just this one reference to background image.
  • Obviously failing integration tests not ideal but from discussions you linked fix does not seem that bad (moving from public to src folders)

@mattxwang
Copy link
Member Author

Update - turns out our icons also use this pathing 😢 . I'll update them first, then circle back.

@mattxwang
Copy link
Member Author

Hm, I am ... messing up this force-merge. Sorry for the notifs Evan, will re-push.

@mattxwang mattxwang merged commit 2d7a8b9 into master May 13, 2021
@mattxwang mattxwang deleted the update-react-scripts-v4 branch May 13, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update react-scripts (CRA) to v4
2 participants