kpash update samtools version #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashpatel6
approved these changes
Oct 17, 2023
CHANGELOG.md
Outdated
| @@ -10,6 +10,9 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| ## [Unreleased] | |||
|
|
|||
| --- | |||
| ## [1.18] 2023-09-26 | |||
There was a problem hiding this comment.
For the date, it should be today's date; the date in the CHANGELOG is for when changes were made in the repo rather than dates related to any tools in the repo
There was a problem hiding this comment.
that makes sense will fix now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed SamTools Version to 1.18
Closes #10
Testing Results
Docker Image Testing
docker runcommand as described below.Test the Docker image with at least one sample. Verify the new Docker image works using:
docker run -u $(id -u):$(id -g) –w <working-directory> -v <directory-you-want-to-mount>:<how-you-want-to-mount-it-within-the-docker> --rm <docker-image-name> <command-to-the-docker-with-all-parameters>My command:
docker run --rm -u$(id -u):$ (id -g) samtools:latest samtools --version
output:
samtools 1.18
Using htslib 1.18
Copyright (C) 2023 Genome Research Ltd.
Checklist
Formatting
I have read the code review guidelines and the code review best practice on GitHub check-list.
The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have set up or verified the branch protection rule following the github standards before opening this pull request.
File Updates
I have ensured that the version number update follows the versioning standards.
I have updated the version number in the
Dockerfile,README.mdandmetadata.yamlfiles.I have updated the dependencies and added my name to the maintainer list in the
Dockerfile.I have updated the feature changes in the
README.md(optional).I have added the changes included in this pull request to the
CHANGELOG.mdunder the next release version or unreleased, and updated the date.GitHub Packages Auto Build Rules
I have not manually pushed this Docker image to the uclahs-cds container registry (
ghcr.io/uclahs-cds) on GitHub.I have updated the
image_namein themetadata.yamlwhich is required by GitHub action to automatically build and push the image.