Changes for building Docker images in Circle CI as part of the CI process #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocess, contains the following changes: * Regenerated the Master key. * Modified Dockerfile of treatment-database app to remove postgres dependencies, as these are meant to run with a MySQL Database, and removing unnecessary dependencies will reduce docker image size. * Modified Dockerfile of treatment-database app to make `RAILS_MASTER_KEY` an argument to the Docker image build instead of an environment variable. This helps separate the build time requirements from runtime requirements. * Added `.dockerignore` to make sure unnecessary files in the repo are not copied as part of the Docker build context.
…ocess, contains the following changes: * Fixed AWS CLI Commands in Circle CI, for some reason the `aws ecr get-login-password` command was outputting 5 unnecessary characters in beginning before the actual output, fixed it for now by trimming those characters using a `cut` command.
…ocess, contains the following changes: * Using a short SHA1 commit ID, instead of the full one to tag the Docker image.
…ocess, contains the following changes: * Using a short SHA1 commit ID, instead of the full one to tag the Docker image.
…ocess, contains the following changes: * Using a short SHA1 commit ID, instead of the full one to tag the Docker image. * Uses CIRCLE_TAG variable if available for tagging the Docker image.
…ocess, contains the following changes: * Setting a Job level environment variable for `AWS_DEFAULT_REGION`.
…ocess, contains the following changes: * Separating build and publish of Docker image into 2 jobs.
…ocess, contains the following changes: * Separating build and publish of Docker image into 2 jobs.
…ocess, contains the following changes: * Separating build and publish of Docker image into 2 jobs.
…ocess, contains the following changes: * Renamed `ruby2-6-6` job to `build`.
…ocess, contains the following changes: * Refined `IMAGE_TAG` logic to pick up version properly from `CIRCLE_TAG` variable, if `CIRCLE_TAG` is of the form `v0.1.0` then `IMAGE_TAG` will be `0.1.0`. * Modified `ci` Circle CI Workflow to run `publish-image` stage only for `qa` branch.
bhanutejags
changed the title
bhanutejags
changed the title
…ocess, contains the following changes: * Using a short SHA1 commit ID, instead of the full one to tag the Docker image.
…ocess, contains the following changes: * Added `rails db:seed` command to README.md. * Modified `docker-compose.yml` to pass `RAIL_MASTER_KEY` as an argument to Docker build.
hortongn
approved these changes
Mar 8, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for building Docker images in Circle CI, as part of the CI process, contains the following changes:
RAILS_MASTER_KEYan argument to the Docker image build instead of an environment variable. This helps separate the build time requirements from runtime requirements..dockerignoreto make sure unnecessary files in the repo are not copied as part of the Docker build context.aws ecr get-login-passwordcommand was outputting 5 unnecessary characters in beginning before the actual output, fixed it for now by trimming those characters using acutcommand.AWS_DEFAULT_REGION.ruby2-6-6job tobuild.IMAGE_TAGlogic to pick up version properly fromCIRCLE_TAGvariable, ifCIRCLE_TAGis of the formv0.1.0thenIMAGE_TAGwill be0.1.0.ciCircle CI Workflow to runpublish-imagestage only forqabranch.