-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSIS-9160] Dissertation Migration BS5 #151
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deux points à noter principalement :
- chargement d'un fichier JS non minifié ?
- traduction qui me paraît être en ano dans certains cas (ptet un search & replace trop violent)
{% endblock %} | ||
{% block script %} | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/dataTables.bootstrap5.js' %}"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal que ce ne soit pas la version minifiée ?
templates/dissertations_list.html
Outdated
<script type="text/javascript" src="{% static 'js/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/dataTables.bootstrap.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/dataTables.bootstrap5.js' %}"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
même question :-)
@@ -406,7 +408,7 @@ <h3 class="panel-title">{% trans 'Your dissertations history' %}</h3> | |||
|
|||
"sProcessing": "{% trans 'Processing...'%}", | |||
"sSearch": "{% trans 'Search:'%}", | |||
"sLengthMenu": "{% trans 'Show _MENU_ entries'%}", | |||
"sLengthMenu": "_MENU_ éléments", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tu l'as mis en français on dirait, je pense que tu dois garder l'ancienne trad° ?
<script type="text/javascript" src="{% static 'js/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/dataTables.bootstrap.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/dataTables.bootstrap5.js' %}"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem :-)
@@ -323,7 +330,7 @@ <h5>{% trans 'Advanced search' %} | |||
|
|||
"sProcessing": "{% trans 'Processing...'%}", | |||
"sSearch": "{% trans 'Search:'%}", | |||
"sLengthMenu": " _MENU_ éléments", | |||
"sLengthMenu": "_MENU_ éléments", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Là cette trad me paraît correcte, la version anglaise doit donc être en ano.
<script type="text/javascript" src="{% static 'js/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/dataTables.bootstrap.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/dataTables.bootstrap5.js' %}"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.min ?
<script type="text/javascript" src="{% static 'js/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/dataTables.bootstrap.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/dataTables.bootstrap5.js' %}"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.min ?
<script type="text/javascript" src="{% static 'js/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/dataTables.bootstrap.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/dataTables.bootstrap5.js' %}"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.min ?
<script type="text/javascript" src="{% static 'js/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/dataTables.bootstrap.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/dataTables.bootstrap5.js' %}"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.min ?
templates/manager_students_list.html
Outdated
<script type="text/javascript" src="{% static 'js/bootstrap.min.js'%}"></script> | ||
<script type="text/javascript" src="{% static 'js/dataTables.bootstrap.min.js'%}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/jquery.dataTables.min.js' %}"></script> | ||
<script type="text/javascript" src="{% static 'js/bootstrap5/dataTables.bootstrap5.js' %}"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.min ?
@leboiss up ? |
J'ai ajouté le fichier dataTable.bootstrap5.min.js il est dans cette PR Concernant les traductions il n'y a pas d'anomalies, sur certaines pages il y a avait marqué "Afficher" devant un select pour définir combien d'éléments on souhaite afficher mais il n'était pas présent sur d'autres pages, j'ai uniformisé les pages en enlevant ce texte |
25e6098
to
1ab8741
Compare
Référence Jira : OSIS-9160
Cette Pr est lié à la PR suivante
dev...feature/OSIS-9160