Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links pointing to the directory itself in wwwpublic #4

Open
Bjarke42 opened this issue Feb 17, 2023 · 2 comments
Open

Links pointing to the directory itself in wwwpublic #4

Bjarke42 opened this issue Feb 17, 2023 · 2 comments
Labels
enhancement New feature or request wishlist Tasks or features of lowest priority

Comments

@Bjarke42
Copy link

In the html area state/wwwpublic, there are links like public and letsencrypt that points to the directory itself.

example:

# ls -ld public
lrwxrwxrwx 1 mig mig 1 Jan 23 10:51 public -> .

It should not be necessary to have links that points to the directory itself. Any automation which has to do operations on the catalogue might encounter problems with such links, because they point to then selves and becomes a loop.

jonasbardino added a commit that referenced this issue Apr 5, 2023
…dor dir to close dependabot vulnerability warning #1, #2, #3 and #4

git-svn-id: svn+ssh://svn.code.sf.net/p/migrid/code/trunk@5684 b75ad72c-e7d7-11dd-a971-7dbc132099af
jonasbardino added a commit that referenced this issue Apr 5, 2023
…dor dir to close dependabot vulnerability warning #1, #2, #3 and #4

git-svn-id: svn+ssh://svn.code.sf.net/p/migrid/code/trunk@5684 b75ad72c-e7d7-11dd-a971-7dbc132099af
@jonasbardino jonasbardino added the enhancement New feature or request label Jul 6, 2023
@benibr
Copy link

benibr commented Aug 3, 2023

Are there any reasons why those links are needed? Not being able to do a recursive operation on the folder is quite annoying.

I guess it's only those two links that Bjarke mentioned:

[root@dstorweb01tl migrid_state]# find -L . > /dev/null
find: File system loop detected; './wwwpublic/letsencrypt' is part of the same file system loop as './wwwpublic'.
find: File system loop detected; './wwwpublic/public' is part of the same file system loop as './wwwpublic'.

@jonasbardino
Copy link
Contributor

I'm pretty sure the letsencrypt link is used by LetsEncrypt looking for /letsencrypt/.well-known/XYZ files during HTTP-01 domain verification. Our security.txt on the other hand needs files to be inside /.well-known/ (e.g. https://erda.ku.dk/.well-known/security.txt) .
It would probably be possible to restructure and eliminate the self-links, but I really can't find the time to do so and test it doesn't break things, sorry. Can't you just use find without the -L arg or with find -H TARGET ?

@jonasbardino jonasbardino added the wishlist Tasks or features of lowest priority label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wishlist Tasks or features of lowest priority
Projects
None yet
Development

No branches or pull requests

3 participants