Update #7
Open
Update #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the run method into separate methods for each phase. Added input validation for command-line arguments and config file handling. Replaced map with lambda using for loops for better readability. Used context managers for file handling. Added some docstrings for better documentation. Made variable names more descriptive.
Make ADBDriver instance a parameter of the BltLogAnalyzer constructor. Make LOCAL_LOGFILE_PATH and REMOTE_LOGFILE_PATH configurable. Create a context manager for handling the log file. Separate the updating of _keep_alives into a dedicated method. Remove or use the _is_keep_alive method. Separate the responsibilities in the get_new_sent_packet_ts method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.