Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header sizes need more differentiation #44

Closed
teresasilva71 opened this issue May 9, 2022 · 2 comments
Closed

Header sizes need more differentiation #44

teresasilva71 opened this issue May 9, 2022 · 2 comments
Assignees
@knice
Labels
bug Something isn't working
Milestone
Pilot Partner Launch

Comments

@teresasilva71
Copy link

This page that Adam created uses both H2 and H3 headers. The size looks to be the same?

header size
@teresasilva71 teresasilva71 added the bug Something isn't working label May 9, 2022
@knice
Copy link
Member

knice commented May 9, 2022

This will be fixed in the next theme release

@knice knice self-assigned this May 9, 2022
@knice knice added this to the Pilot Partner Launch milestone May 9, 2022
knice added a commit that referenced this issue May 10, 2022
@knice
Normalize style defaults (#49)
6694b9b 
## Highlights

- Resolves #48 and #44
- De-complicate styles for buttons by bringing CSS for buttons into the block stylesheet.
- Merge 😳 @Herm71 responsive CSS into footer partial, and use theme gap settings to space footer elements more clearly.
- Set sensible, fluid defaults for spacing (line height and spacing variables), typography (sizes), and gaps.
- Simplify block layout width settings by removing wide. Settings are now just layout width or full-bleed.
- Increase layout width from 1080px to 1280px.  

## Commits

* feat: ⚡️ Update font-stack to variable version of Roboto
* feat: ⚡️ Add fluid type scale for font sizes in the theme
* feat: ⚡️ Post subtitle font-size adjustment
* style: 🎨 Update default blockGap to 1.25rem
* style: 🎨 Set main nav font-size to one of the new defaults
* fix: 🚑️ Clean up block styles setup. Add draft style for spacer; move CSS for button styles to button.css file
* refactor: 🎨 Clean up styles and set clear, theme-based spacing in footer
@knice
Copy link
Member

knice commented May 11, 2022

This is resolved in 1.0.0-rc.3 of the theme, which will be live on CP on 2022-05-11.

@knice knice closed this as completed May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knice knice

Labels
bug Something isn't working
Projects
None yet
Milestone
Pilot Partner Launch
Development

No branches or pull requests
2 participants
@knice @teresasilva71