Confusing wording in test from task 2

[samraul]

nd1309-p2-Decentralized-Star-Notary-Service-Starter-Code/test/TestStarNotary.js

Lines 78 to 81 in ad8d65e

	it('can add the star name and star symbol properly', async() => {
	// 1. create a Star with different tokenId
	//2. Call the name and symbol properties in your Smart Contract and compare with the name and symbol provided
	});

This test seems to be mixing the concepts of star information vs contract information.

• There is no such thing as star symbol
• There is no need to create a star to check the contract name and symbol
• When it asks to compare versus name and symbol provided, it does not state where they are provided.
  • The properties should probably be in the constructor, so perhaps it should state so?

Thanks.

[jungleBadger]

Hi there, @samraul. Thanks for your concern; let me address your points below:

1. The star symbol is required and can be available through 02 main strategies: Hardcoded value in all Stars created by your Smart Contract or receiving it as a variable in the Constructor.
2. You are correct; you need to check against one created in previous steps. The students are free to create a new one if they wish to.
3. They are properties available in all Stars created in your Smart Contract.
4. As I disclaimed in point 1 above, it is not mandatory to be in the Constructor.

Finally, here is the highlight from the project's rubric disclaiming the usage of the Star symbol: