Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: angular dependency, remove fakerjs, nguniversal demo app #123

Merged
merged 7 commits into from
Feb 1, 2022
Merged

fix: angular dependency, remove fakerjs, nguniversal demo app #123

merged 7 commits into from
Feb 1, 2022
+4,693 −2,108

Conversation

udayvunnam
Copy link
Owner

What is this PR about

fixes #118

PR Checklist

Please check if your PR fulfils the following requirements:

  • The commit message follows the guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

@github-actions
Copy link

Hello 👋 @udayvunnam
Thank you for raising your pull request. Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

@udayvunnam udayvunnam changed the title fix: incompatible dependency and remove fakerjs fix: angular dependency, remove fakerjs, nguniversal demo app Feb 1, 2022
@udayvunnam udayvunnam merged commit 8cd1f98 into main Feb 1, 2022
@udayvunnam udayvunnam deleted the fix-incompat-dep branch February 1, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package "xng-breadcrumb" has an incompatible peer dependency to "@angular/platform-browser-dynamic"
1 participant
@udayvunnam