fix: Removed role="button" attribute from .xng-breadcrumb-link #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The a.xng-breadcrumb-link elements in the breadcrumb navigation are interpreted as buttons for assistive technologies due to role="button" attribute, even though they are clearly links (and not buttons). The role="button" attribute should be removed.
ovidiu-cssrl
changed the title
udayvunnam
approved these changes
Dec 1, 2022
udayvunnam
approved these changes
Dec 1, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The a.xng-breadcrumb-link elements in the breadcrumb navigation are interpreted as buttons for assistive technologies due to role="button" attribute, even though they are clearly links (and not buttons). The role="button" attribute should be removed.
What is this PR about
The a.xng-breadcrumb-link elements in the breadcrumb navigation are interpreted as buttons for assistive technologies due to role="button" attribute, even though they are clearly links (and not buttons). The role="button" attribute has been removed.
PR Checklist
Please check if your PR fulfils the following requirements: