begin of development #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andskur
requested changes
Nov 15, 2021
|
|
||
| let pqEnabled: bool = (configParser.getParam("postgres.enabled") == Some("1")); | ||
| // C++: postgresHelper->setEnabled(pqEnabled); | ||
| if pqEnabled { |
There was a problem hiding this comment.
Is better to implement all db related stuff later. We don't need database for the first prototype
There was a problem hiding this comment.
With what we should replace db? We need sth to show that project is working correctly, right? Or we need to write code that just compiles, but test its work later?
And what about loggingHelper? Should we implement it later too?
There was a problem hiding this comment.
- Just log something - "service is running"
- LoggingHelper is oke
andskur
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.