feat: simplify previous char pattern and move default option to creat…

…eMentionPlugin
udecode · Jul 27, 2023 · c6f5967 · c6f5967
1 parent bf8d5c8
commit c6f5967
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/apps/www/content/docs/mention.mdx b/apps/www/content/docs/mention.mdx
@@ -65,7 +65,7 @@ A function to create the mention node.
 </APIItem>
 <APIItem name="triggerPreviousCharPattern" type="RegExp" optional>
   The pattern that matches the char before the trigger character
-  (default to `/^$|^\s$/` that matches beginning of line or space)
+  (default to `/^\s?$/` that matches beginning of line or space)
 </APIItem>
 
 <APIItem name="inputCreation" type="{ key: string; value: string }" optional>

diff --git a/packages/mention/src/createMentionPlugin.ts b/packages/mention/src/createMentionPlugin.ts
@@ -22,6 +22,7 @@ export const createMentionPlugin = createPluginFactory<MentionPlugin>({
   withOverrides: withMention,
   options: {
     trigger: '@',
+    triggerPreviousCharPattern: /^\s?$/,
     createMentionNode: (item) => ({ value: item.text }),
   },
   plugins: [

diff --git a/packages/mention/src/withMention.ts b/packages/mention/src/withMention.ts
@@ -114,11 +114,8 @@ export const withMention = <
         getPointBefore(editor, editor.selection)
       )
     );
-
-    const spaceOrEmptyPattern = /^$|^\s$/;
-    const previousCharPattern =
-      triggerPreviousCharPattern ?? spaceOrEmptyPattern;
-    const matchesPreviousCharPattern = previousCharPattern.test(previousChar);
+    const matchesPreviousCharPattern =
+      triggerPreviousCharPattern?.test(previousChar);
 
     if (matchesPreviousCharPattern && text === trigger) {
       const data: TMentionInputElement = {