Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2230: Stop accidental infinite recursion #2233

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Conversation

fimion
Copy link
Contributor

@fimion fimion commented Feb 23, 2023

Description

See changesets.

Add check for then being replaced. This will fix #2230.

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023

🦋 Changeset detected

Latest commit: d0bec47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 68 packages
Name Type
@udecode/plate-core Patch
@udecode/plate-button Patch
@udecode/plate-cloud Patch
@udecode/plate-comments Patch
@udecode/plate-find-replace Patch
@udecode/plate-autoformat Patch
@udecode/plate-break Patch
@udecode/plate-combobox Patch
@udecode/plate-node-id Patch
@udecode/plate-normalizers Patch
@udecode/plate-reset-node Patch
@udecode/plate-select Patch
@udecode/plate-tabbable Patch
@udecode/plate-trailing-block Patch
@udecode/plate-floating Patch
@udecode/plate-headless Patch
@udecode/plate-media Patch
@udecode/plate-alignment Patch
@udecode/plate-basic-elements Patch
@udecode/plate-basic-marks Patch
@udecode/plate-block-quote Patch
@udecode/plate-code-block Patch
@udecode/plate-emoji Patch
@udecode/plate-font Patch
@udecode/plate-heading Patch
@udecode/plate-highlight Patch
@udecode/plate-horizontal-rule Patch
@udecode/plate-indent-list Patch
@udecode/plate-indent Patch
@udecode/plate-kbd Patch
@udecode/plate-line-height Patch
@udecode/plate-link Patch
@udecode/plate-list Patch
@udecode/plate-mention Patch
@udecode/plate-paragraph Patch
@udecode/plate-table Patch
@udecode/plate-selection Patch
@udecode/plate-serializer-csv Patch
@udecode/plate-serializer-docx Patch
@udecode/plate-serializer-html Patch
@udecode/plate-juice Patch
@udecode/plate-serializer-md Patch
@udecode/plate-ui-button Patch
@udecode/plate-ui-cloud Patch
@udecode/plate-ui-combobox Patch
@udecode/plate-ui-comments Patch
@udecode/plate-ui-cursor Patch
@udecode/plate-ui-dnd Patch
@udecode/plate-ui-find-replace Patch
@udecode/plate-ui-alignment Patch
@udecode/plate-ui-block-quote Patch
@udecode/plate-ui-code-block Patch
@udecode/plate-ui-emoji Patch
@udecode/plate-ui-excalidraw Patch
@udecode/plate-ui-font Patch
@udecode/plate-ui-horizontal-rule Patch
@udecode/plate-ui-line-height Patch
@udecode/plate-ui-link Patch
@udecode/plate-ui-list Patch
@udecode/plate-ui-media Patch
@udecode/plate-ui-mention Patch
@udecode/plate-ui-table Patch
@udecode/plate-ui-placeholder Patch
@udecode/plate-ui-popper Patch
@udecode/plate-styled-components Patch
@udecode/plate-ui-toolbar Patch
@udecode/plate Patch
@udecode/plate-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
plate ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 1:40AM (UTC)
plate-examples ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 1:40AM (UTC)

@ghost
Copy link

ghost commented Feb 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@vercel vercel bot temporarily deployed to Preview – plate-examples February 23, 2023 19:50 Inactive
@vercel vercel bot temporarily deployed to Preview – plate February 23, 2023 19:51 Inactive
@vercel vercel bot temporarily deployed to Preview – plate-examples February 23, 2023 20:01 Inactive
@vercel vercel bot temporarily deployed to Preview – plate February 23, 2023 20:02 Inactive
@zbeyens
Copy link
Member

zbeyens commented Feb 24, 2023

@fimion Seems like it is breaking a unit test

@fimion
Copy link
Contributor Author

fimion commented Feb 24, 2023

I'll take a look at it this weekend.

@vercel vercel bot temporarily deployed to Preview – plate-examples February 25, 2023 18:53 Inactive
@vercel vercel bot temporarily deployed to Preview – plate February 25, 2023 18:54 Inactive
@zbeyens zbeyens merged commit 8c15238 into udecode:main Feb 27, 2023
@vercel vercel bot temporarily deployed to Preview – plate-examples February 27, 2023 01:39 Inactive
@vercel vercel bot temporarily deployed to Preview – plate February 27, 2023 01:40 Inactive
@github-actions github-actions bot mentioned this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RangeError: Maximum call stack size exceeded - overridePluginsByKey.ts
2 participants