Apply isUrl option to pasted links #2239 #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 20cb889 The changes in this PR will be included in the next version bump. This PR includes changesets to release 68 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@OliverWales Thanks for the PR! I've emailed you about this on the address on your GitHub profile. |
12joan
force-pushed
the
pasted-link-validation
branch
from
1c373f2
to
575a2d4
Compare
zbeyens
previously approved these changes
Feb 27, 2023
zbeyens
reviewed
Feb 28, 2023
zbeyens
reviewed
Feb 28, 2023
zbeyens
reviewed
Feb 28, 2023
12joan
force-pushed
the
pasted-link-validation
branch
from
5cd9d48
to
20cb889
Compare
zbeyens
approved these changes
Feb 28, 2023
This was referenced Feb 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links that are pasted as text are detected using the link plugin. Links pasted as HTML are not, leading to #2239.
This PR applies the
isUrloption, if present, to the href of any pasted<a />tag, and falls back to pasting as text if the href is not deemed to be a URL.Realise this might be quite opinionated and/or a breaking change so happy to create a new "should validate pasted links" flag if preferred.