Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update no-OS-FatFS-SD-SDIO-SPI-RPi-Pico RISC-V code; reduce source code duplication #467

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

sneakywumpus
Copy link
Contributor

Changes to not disturb the ARM side of things.

…request

Changes to not disturb the ARM side of things.
Rename CMakeLists.txt.corev to CMakeLists.txt.riscv.

Move no-OS-FatFS-SD-SDIO-SPI-RPi-Pico, stdio_msc_usb, and ds3231
into new libs top-level directory.

Restore ds3231 to its full glory from https://github.com/antgon/pico-ds3231.

Reduces a lot of source code duplication and makes it easier to
update these.
Also change "pico_arm_gcc" to "pico_arm_cortex_m0plus_gcc" to avoid a
notice.
@udo-munk
Copy link
Owner

udo-munk commented Dec 6, 2024

I thought I update to the latest FatFS version now everywhere where it is included. Then this won't be necessary?

@sneakywumpus
Copy link
Contributor Author

It's currently only in the dev branch.

@sneakywumpus
Copy link
Contributor Author

Arghh.. Sorry just pushed a bunch of other stuff intended for the next pull request...

@sneakywumpus sneakywumpus changed the title no-OS-FatFS-SD-SDIO-SPI-RPi-Pico: update code to match accepted pull request update no-OS-FatFS-SD-SDIO-SPI-RPi-Pico RISC-V code; reduce source code duplication Dec 6, 2024
@udo-munk udo-munk merged commit 7785987 into udo-munk:dev Dec 6, 2024
@udo-munk
Copy link
Owner

udo-munk commented Dec 6, 2024

No problem, this is better anyway. I tried to move the libs to some common lib dir before, but failed with that cmake stuff ;-)

@sneakywumpus
Copy link
Contributor Author

Yeah, I don't know if this is the proper cmake-way but it works...

I had another idea: how about merging RP2040-GEEK-80 into z80pack proper? picosim shares a lot of stuff with it.
Thoughts?

@udo-munk
Copy link
Owner

udo-munk commented Dec 6, 2024

Yep, works.

Please don't. There are many many people who just like to use the GEEK CP/M machine, but are not able to setup the SDK and compile it them self. That is why I added a directory with the latest build, so that they just have to flash it. I also would like to create another repo for the RP2350-GEEK when the devices arrive, to make it as easy as possible for those who just want to use it. The z80pack repo is complex enough already.

@sneakywumpus
Copy link
Contributor Author

Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants