Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last missing API piece I can think of:
A thing decoding might want to ask the decoder if it knows what type is being decoded.
Previously this was handled through
Decoder::type_hint
, but this has a runtime penalty: The returnedTypeHint
needs to be matched over.Instead for this we adopt a modified Visitor pattern from serde, the twist being that the visitor can produce its own sub-visitors:
type String
,type Bytes
andtype Number
. This makes visitors more composable since it's a more granular set of traits you need to implement and use instead of one bigVisitor
trait.The
#[musli::visitor]
attribute also has to be added to allow for API evolution.This is what its use looks like in
musli-value
: