Descriptive integers #132
Merged
Descriptive integers #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udoprog
force-pushed
the
desriptive-integers
branch
from
225c97a
to
6929cd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where data encoded in musli-descriptive would be incorrectly decoded in case there is a type-mismatch.
For example, if a i32 is decoded as a u32, zigzag encoding (if enabled) would cause the integer to be twice as wide when continuation-decoded.
This patch ensures that the available type information is used during decoding, and coerces integers into the appropriate format.
Also fixes an encoding mismatch with
[T; N]arrays.