Porting to 8.15 #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyoDralliam
reviewed
Jan 29, 2024
| @@ -1,13 +1,13 @@ | |||
| module ZipSeqAlternative = struct | |||
| type 'a t = 'a Stdlib.Seq.t | |||
|
|
|||
| let zip xs ys () = | |||
| let rec zip xs ys () = | |||
There was a problem hiding this comment.
I think this rec is ambiguous: for Stdlib version < 4.14, Stdlib.Seq.zip is not defined hence the recursive call is used, but in versions >= 4.14 the function zip is defined in the lib and this rec is unused... And similar for drop below.
There was a problem hiding this comment.
Yeah, it's been a source of confusion and back and forth issues… I am no OCaml expert, do you know how to disambiguate to give priority to the local recursively defined function? Or maybe we should drop (this part of) the monadic library, which seems to be stuck with 4.13?
|
done, I pushed your branch to this repo now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to get a CI run.