Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Green bar at the bottom of certain videos #25

Closed
gmpreussner opened this issue Oct 12, 2016 · 4 comments
Closed

Green bar at the bottom of certain videos #25

gmpreussner opened this issue Oct 12, 2016 · 4 comments
Assignees

Comments

@gmpreussner
Copy link
Contributor

Some videos show a green bar at the bottom.

The problem is that VLC sometimes allocates buffers that are larger than the display dimensions of the video. Buffer dimensions and display dimensions are separate concepts. The media framework API does not currently support this, and it expects both to be the same.

@gmpreussner
Copy link
Contributor Author

Mentioned in #17

@gmpreussner gmpreussner self-assigned this Oct 12, 2016
@gmpreussner
Copy link
Contributor Author

I'm going to address this as part of the timecode related refactor for 4.15. Since we cannot clamp the sampling of the buffer (render device specific), I think we need to clamp the buffer in a shader instead, similar to what we're doing in PS4Media.

@gmpreussner
Copy link
Contributor Author

This will be fixed in the UE4 Master branch on Wednesday 10/26

@gmpreussner
Copy link
Contributor Author

This is fixed starting with ce06caf

(requires 4.15 code, which isn't on Github yet - will be merged up November 23rd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant