-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from setuptools/distutils to meson #23
Conversation
Replaces usage of distutils to build c extension with meson/meson-python. This requires replacing the `setup.py` file with a `pyproject.toml` file, which makes it harder to infer project properties from the python source.
yes this is a work towards #9 #13 #14 i guess @ionenwks @pirate486743186 and @eli-schwartz will be happy to know this is finally getting worked on. |
Nice. The meson.build part looks mostly like the one minimally tested and suggested at #14 (comment) but the summary() usage is new. IIRC meson already prints settings that were changed from the defaults, although py_install_dir isn't a setting to change so still possibly good to see. I'm not sure whether the other settings (get_option usages) even matter for ueberzug's use case? In theory you could just elide printing those. :) |
i thought so at first, but since the long term intention is to try and have some feature parity with U++ they could come in handy in the future. also there is another rather pressing problem, which is that the distribution name |
will figure this one later, will test some stuff and hopefully merge this today. |
lol, lmao even. |
You don't get a high score until you've delayed merging your own PR by a couple of years. :P (Been there, done that, hid the t-shirt in the back of the drawer.) |
initial work to fully migrate towards meson, huge thanks to karna for not just sending the patch but testing that it builds under debian testing.
as outlined on the patch comment there is still work to do.