Conditionally fetch email #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #77 |
yordis
reviewed
May 27, 2023
| @@ -175,7 +175,7 @@ defmodule Ueberauth.Strategy.Github do | |||
| name: user["name"], | |||
| description: user["bio"], | |||
| nickname: user["login"], | |||
| email: fetch_email!(user, allow_private_emails), | |||
| email: maybe_fetch_email(user, allow_private_emails), | |||
There was a problem hiding this comment.
Is there any reason we couldn't update fetch_email! to avoid raising an error?
There was a problem hiding this comment.
This is one of two places where fetch_email! used to be used. The other one seems to be a legit place for raising with the expectation of the field existence.
Also, get_primary_email! and get_private_email! do no raise, so I could clean them up to have no ! in the names and call maybe_fetch_email from fetch_email!.
yordis
approved these changes
May 27, 2023
There was a problem hiding this comment.
Hey, do you mind adding an entry to https://github.com/ueberauth/ueberauth_github/blob/master/CHANGELOG.md
Otherwise, let me know and I merge it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a very sophisticated approach to simply ignore email. But I couldn't discover any immediate punishment and it seems to simply return a valid
%Ueberauth.Authstruct withnilforemailfield along with othernilfor a bunch of other data that is beyond the scope.