Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scope splitting #104

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix scope splitting #104

merged 2 commits into from
Nov 14, 2023

Conversation

aptinio
Copy link
Contributor

@aptinio aptinio commented Nov 13, 2023

No description provided.

@aptinio aptinio requested a review from a team as a code owner November 13, 2023 09:28
@yordis
Copy link
Member

yordis commented Nov 13, 2023

Hey there, thank you so much for the contribution. Do you mind update https://github.com/ueberauth/ueberauth_google/blob/master/CHANGELOG.md and bump the version in the mix.exs so we could release it?

@aptinio
Copy link
Contributor Author

aptinio commented Nov 14, 2023

Don't mind at all. Thanks @yordis!

@yordis yordis merged commit 6a647c3 into ueberauth:master Nov 14, 2023
2 checks passed
@aptinio aptinio deleted the fix-scope-splitting branch November 14, 2023 14:11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yordis, I didn't realize until now that my editor formatted this file (using Prettier). Sorry about that 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, it is not your fault. I need to put Actions in place that helps with these things honestly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants