Allow Ueberauth 0.9.0 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ueberauth 0.9 does not seem to introduce any compatibility issues with ueberauth_google
|
hey there, do you mind running |
|
@yordis done, but not much to format. appologies, I did not branch from my side, so guess that is why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ueberauth 0.9.0 does not seem to have any compatibility issues with ueberauth_google:
https://github.com/ueberauth/ueberauth/blob/master/CHANGELOG.md#v090---2022-04-27
https://diff.hex.pm/diff/ueberauth/0.7.0..0.9.0
Tested this change locally and have a uat environment deploy seeming to work.
It might be valuable to leave the 0.7.0 option as it seems to work for both still and don't want to force unnecessary upgrades.