Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordered list start attribute name #32

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

jacksleight
Copy link
Contributor

@jacksleight jacksleight commented Feb 11, 2023

Tiptap stores an ordered lists start attribute as start (which is the correct attribute name), but this package is looking for an order attribute instead.

This PR changes it to start so that data created with Tiptap renders correctly in Tiptap PHP.

Closes #47

@jacksleight jacksleight changed the title Rename ordered list order attr to start Fix ordered list start attribute name May 17, 2023
@merlijnvanlent
Copy link

+1
I am also running into this issue. Especially with Statamic content editing. Hopefully this can be fixed soon.

@kristiana-s
Copy link

+1 Running into this issue also within Statamic editing, especially lists. Would be great to see a fix

@JshGrn
Copy link

JshGrn commented Apr 4, 2024

Can we get this merged by any chance I have just noticed I opened an issue about this.... Otherwise will need to fork and merge in which is not something I want to be doing/maintaining... Why is this so quiet?

@JshGrn
Copy link

JshGrn commented Jun 25, 2024

Why are we entering July and this has not been merged? Can somebody please review and or merge this, I really don't want to be using forked versions in production. There has been zero response from the maintainers of this package about this.. @timoisik any thoughts?

Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We appreciate your contribution, sorry the original maintainer of this package has left the company so support for this package has fallen between the cracks

@nperez0111 nperez0111 merged commit b1c5269 into ueberdosis:main Aug 12, 2024
@JshGrn
Copy link

JshGrn commented Aug 12, 2024

I did think that would have been the case but wasn't sure. This is perfect thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ordered List incompatible with Tiptap JS
5 participants