fix(core): isNodeSelection, isTextSelection not always false (#3089)

Fixes #2979. Since the ProseMirror TypeScript upgrade, these have always returned false, since the Selection type tree are all classes now.
ueberdosis · Aug 22, 2022 · 574cd69 · 574cd69
1 parent 2ca1a7b
commit 574cd69
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 42 deletions.
diff --git a/packages/core/src/helpers/isNodeSelection.ts b/packages/core/src/helpers/isNodeSelection.ts
@@ -1,7 +1,5 @@
 import { NodeSelection } from 'prosemirror-state'
 
-import { isObject } from '../utilities/isObject'
-
 export function isNodeSelection(value: unknown): value is NodeSelection {
-  return isObject(value) && value instanceof NodeSelection
+  return value instanceof NodeSelection
 }
diff --git a/packages/core/src/helpers/isTextSelection.ts b/packages/core/src/helpers/isTextSelection.ts
@@ -1,7 +1,5 @@
 import { TextSelection } from 'prosemirror-state'
 
-import { isObject } from '../utilities/isObject'
-
 export function isTextSelection(value: unknown): value is TextSelection {
-  return isObject(value) && value instanceof TextSelection
+  return value instanceof TextSelection
 }
diff --git a/packages/core/src/utilities/isClass.ts b/packages/core/src/utilities/isClass.ts
diff --git a/packages/core/src/utilities/isObject.ts b/packages/core/src/utilities/isObject.ts
diff --git a/tests/cypress/integration/core/isClass.spec.ts b/tests/cypress/integration/core/isClass.spec.ts