fix: fix a bug when parsing attributes if no parseHTML method is prov…

…ided, fix #2058
ueberdosis · Nov 8, 2021 · 5da313a · 5da313a
1 parent c94d2b0
commit 5da313a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/core/src/utilities/fromString.ts b/packages/core/src/utilities/fromString.ts
@@ -3,7 +3,7 @@ export default function fromString(value: any): any {
     return value
   }
 
-  if (value.match(/^\d*(\.\d+)?$/)) {
+  if (value.match(/^[+-]?(?:\d*\.)?\d+$/)) {
     return Number(value)
   }
 

diff --git a/tests/cypress/integration/core/fromString.spec.ts b/tests/cypress/integration/core/fromString.spec.ts
@@ -9,6 +9,12 @@ describe('fromString', () => {
     expect(value).to.eq('test')
   })
 
+  it('should return an empty string', () => {
+    const value = fromString('')
+
+    expect(value).to.eq('')
+  })
+
   it('should convert to a number', () => {
     const value = fromString('1')