fix: fix a bug when configurating the same extension multiple times

ueberdosis · May 11, 2021 · 655c564 · 655c564
1 parent 1646f6e
commit 655c564
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 3 deletions.
diff --git a/packages/core/src/Extension.ts b/packages/core/src/Extension.ts
@@ -256,7 +256,9 @@ export class Extension<Options = any> {
   configure(options: Partial<Options> = {}) {
     this.options = mergeDeep(this.options, options) as Options
 
-    return this
+    // return a new instance so we can use the same extension
+    // with different calls of `configure`
+    return this.extend()
   }
 
   extend<ExtendedOptions = Options>(extendedConfig: Partial<ExtensionConfig<ExtendedOptions>> = {}) {

diff --git a/packages/core/src/Mark.ts b/packages/core/src/Mark.ts
@@ -353,7 +353,9 @@ export class Mark<Options = any> {
   configure(options: Partial<Options> = {}) {
     this.options = mergeDeep(this.options, options) as Options
 
-    return this
+    // return a new instance so we can use the same extension
+    // with different calls of `configure`
+    return this.extend()
   }
 
   extend<ExtendedOptions = Options>(extendedConfig: Partial<MarkConfig<ExtendedOptions>> = {}) {

diff --git a/packages/core/src/Node.ts b/packages/core/src/Node.ts
@@ -434,7 +434,9 @@ export class Node<Options = any> {
   configure(options: Partial<Options> = {}) {
     this.options = mergeDeep(this.options, options) as Options
 
-    return this
+    // return a new instance so we can use the same extension
+    // with different calls of `configure`
+    return this.extend()
   }
 
   extend<ExtendedOptions = Options>(extendedConfig: Partial<NodeConfig<ExtendedOptions>> = {}) {

diff --git a/tests/cypress/integration/core/extensionOptions.spec.ts b/tests/cypress/integration/core/extensionOptions.spec.ts
@@ -121,4 +121,29 @@ describe('extension options', () => {
       },
     })
   })
+
+  it('should create its own instance on configure', () => {
+    const extension = Extension
+      .create({
+        defaultOptions: {
+          foo: 1,
+        },
+      })
+
+    const extension1 = extension.configure({
+      foo: 2,
+    })
+
+    const extension2 = extension.configure({
+      foo: 3,
+    })
+
+    expect(extension1.options).to.deep.eq({
+      foo: 2,
+    })
+
+    expect(extension2.options).to.deep.eq({
+      foo: 3,
+    })
+  })
 })