fix(core): fix error when merging class attributes (#4340)

* fix(core): fix error when merging class attributes * added test
ueberdosis · Aug 17, 2023 · a251946 · a251946
1 parent 141dd26
commit a251946
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/demos/src/Marks/Link/React/index.spec.js b/demos/src/Marks/Link/React/index.spec.js
@@ -1,3 +1,5 @@
+import Link from '@tiptap/extension-link'
+
 context('/src/Marks/Link/React/', () => {
   before(() => {
     cy.visit('/src/Marks/Link/React/')
@@ -10,6 +12,18 @@ context('/src/Marks/Link/React/', () => {
     })
   })
 
+  it('should add a custom class to a link', () => {
+    const linkExtension = Link.configure({
+      HTMLAttributes: {
+        class: 'foo',
+      },
+    })
+
+    expect(linkExtension.options.HTMLAttributes).to.deep.include({
+      class: 'foo',
+    })
+  })
+
   it('should parse a tags correctly', () => {
     cy.get('.tiptap').then(([{ editor }]) => {
       editor.commands.setContent('<p><a href="#">Example Text</a></p>')

diff --git a/packages/core/src/utilities/mergeAttributes.ts b/packages/core/src/utilities/mergeAttributes.ts
@@ -14,8 +14,8 @@ export function mergeAttributes(...objects: Record<string, any>[]): Record<strin
         }
 
         if (key === 'class') {
-          const valueClasses: string[] = value.split(' ')
-          const existingClasses: string[] = mergedAttributes[key].split(' ')
+          const valueClasses: string[] = value ? value.split(' ') : []
+          const existingClasses: string[] = mergedAttributes[key] ? mergedAttributes[key].split(' ') : []
 
           const insertClasses = valueClasses.filter(
             valueClass => !existingClasses.includes(valueClass),