feat: remove keepInBounds

ueberdosis · Apr 16, 2021 · d7282f1 · d7282f1
1 parent 9335858
commit d7282f1
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 18 deletions.
diff --git a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts
@@ -6,7 +6,6 @@ import tippy from 'tippy.js'
 export interface BubbleMenuPluginProps {
   editor: Editor,
   element: HTMLElement,
-  keepInBounds: boolean,
 }
 
 export type BubbleMenuViewProps = BubbleMenuPluginProps & {

diff --git a/packages/extension-bubble-menu/src/bubble-menu.ts b/packages/extension-bubble-menu/src/bubble-menu.ts
@@ -10,7 +10,6 @@ export const BubbleMenu = Extension.create<BubbleMenuOptions>({
 
   defaultOptions: {
     element: null,
-    keepInBounds: true,
   },
 
   addProseMirrorPlugins() {
@@ -22,7 +21,6 @@ export const BubbleMenu = Extension.create<BubbleMenuOptions>({
       BubbleMenuPlugin({
         editor: this.editor,
         element: this.options.element,
-        keepInBounds: this.options.keepInBounds,
       }),
     ]
   },

diff --git a/packages/react/src/BubbleMenu.tsx b/packages/react/src/BubbleMenu.tsx
@@ -9,12 +9,11 @@ export const BubbleMenu: React.FC<BubbleMenuProps> = props => {
   const element = useRef<HTMLDivElement>(null)
 
   useEffect(() => {
-    const { editor, keepInBounds = true } = props
+    const { editor } = props
 
     editor.registerPlugin(BubbleMenuPlugin({
       editor,
       element: element.current as HTMLElement,
-      keepInBounds,
     }))
 
     return () => {

diff --git a/packages/vue-2/src/BubbleMenu.ts b/packages/vue-2/src/BubbleMenu.ts
@@ -9,11 +9,6 @@ export const BubbleMenu = Vue.extend({
       type: Object as PropType<BubbleMenuPluginProps['editor']>,
       required: true,
     },
-
-    keepInBounds: {
-      type: Boolean as PropType<BubbleMenuPluginProps['keepInBounds']>,
-      default: true,
-    },
   },
 
   watch: {
@@ -28,7 +23,6 @@ export const BubbleMenu = Vue.extend({
           editor.registerPlugin(BubbleMenuPlugin({
             editor,
             element: this.$el as HTMLElement,
-            keepInBounds: this.keepInBounds,
           }))
         })
       },

diff --git a/packages/vue-3/src/BubbleMenu.ts b/packages/vue-3/src/BubbleMenu.ts
@@ -20,21 +20,15 @@ export const BubbleMenu = defineComponent({
       type: Object as PropType<BubbleMenuPluginProps['editor']>,
       required: true,
     },
-
-    keepInBounds: {
-      type: Boolean as PropType<BubbleMenuPluginProps['keepInBounds']>,
-      default: true,
-    },
   },
 
-  setup({ editor, keepInBounds }, { slots }) {
+  setup({ editor }, { slots }) {
     const root = ref<HTMLElement | null>(null)
 
     onMounted(() => {
       editor.registerPlugin(BubbleMenuPlugin({
         editor,
         element: root.value as HTMLElement,
-        keepInBounds,
       }))
     })