Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focus command seems to be broken in React #1716

Closed
philippkuehn opened this issue Aug 11, 2021 · 0 comments
Closed

focus command seems to be broken in React #1716

philippkuehn opened this issue Aug 11, 2021 · 0 comments
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@philippkuehn
Copy link
Contributor

It seems that the focus command leads to some problems in react or is not working at all. I think it has to do with the fact that React renders asynchronously. Multiple issues are affected:

Every attempt to fix this has failed. Any help is appreciated!
@philippkuehn philippkuehn added Type: Bug The issue or pullrequest is related to a bug help wanted labels Aug 11, 2021
This was referenced Aug 11, 2021
Closed
Closed
andrewlu0 pushed a commit to trybaseplate/tiptap that referenced this issue Oct 20, 2023
@philippkuehn
fix: fix some react focus issues (ueberdosis#1724), fix ueberdosis#1716…
a2fe315 
…, fix ueberdosis#1608, fix ueberdosis#1520

* remove async createNodeViews

* focus asynchronously to fix weird bugs in react
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philippkuehn