Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(React) Content of nested NodeViews will not render until focus #1747

Closed
WilliamIPark opened this issue Aug 18, 2021 · 4 comments
Closed

(React) Content of nested NodeViews will not render until focus #1747

WilliamIPark opened this issue Aug 18, 2021 · 4 comments
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@WilliamIPark
Copy link
Contributor

Description
When nesting NodeViews, the content of the deeper node view will not render until the editor gains focus.

Steps to reproduce the bug
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/tiptap-v2-beta-rendering-bug-yfftj
  2. Notice no text content in the blue box (field node)
  3. Click into the blue box.
  4. Content will appear.

CodeSandbox
I created a CodeSandbox to help you debug the issue:

Expected behavior
The text content should be visible on load.

Environment?

  • operating system: MacOS
  • browser: Chrome / FireFox / Safari all reproduce the issue.
  • tiptap version: 2.0.0-beta.99
@WilliamIPark WilliamIPark added Type: Bug The issue or pullrequest is related to a bug v2 labels Aug 18, 2021
@WilliamIPark
Copy link
Contributor Author

Some additional details here, including how I worked around the issue in certain cases, but I've run into a case where the workaround won't suit:
#1675

@philippkuehn
Copy link
Contributor

I can confirm this issue. It seems to be fixed with this PR. But since that would be a breaking change, I'll have to take another look.

@philippkuehn
Copy link
Contributor

It’s fixed in the latest version of @tiptap/react.

@rssfrncs
Copy link

rssfrncs commented Jan 26, 2023

I've noticed this in the latest v2 are you aware? I have a custom node set to inline which is rendering one of it's attributes as content, when i update the attribute the node does not update until i click it. If instead I set the custom node to block it updates with or without focus.

Further testing i removed the NodeView and this happens with just the standard renderHTML method.

andrewlu0 pushed a commit to trybaseplate/tiptap that referenced this issue Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

3 participants