Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't apply typography when inside the Code mark #1889

Closed
neongreen opened this issue Sep 13, 2021 · 3 comments · Fixed by #1997
Closed

Don't apply typography when inside the Code mark #1889

neongreen opened this issue Sep 13, 2021 · 3 comments · Fixed by #1997
Labels
Type: Feature The issue or pullrequest is a new feature

Comments

@neongreen
Copy link

neongreen commented Sep 13, 2021 •
edited
Loading

When I'm inside a <code> mark, I usually don't want to replace -- with a dash, or have curly quotes, etc. It would be nice to disable typography there.

The CodeBlock node already features this behavior.
@neongreen neongreen added Type: Feature The issue or pullrequest is a new feature v2 labels Sep 13, 2021
@philippkuehn
Copy link
Contributor

I'm currently working on a rewrite of inputrules/pasterules and keep that in mind! ✌️

@philippkuehn
Copy link
Contributor

Do you mean the Code mark or CodeBlock node?

@neongreen
Copy link
Author

The Code mark.

@neongreen neongreen changed the title Don't apply typography when inside code Don't apply typography when inside the Code mark Sep 20, 2021
@hanspagel hanspagel removed the v2 label Sep 28, 2021
@philippkuehn philippkuehn mentioned this issue Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature The issue or pullrequest is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate input rules and paste rules into the core ueberdosis/tiptap
3 participants
@neongreen @hanspagel @philippkuehn