-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate input rules and paste rules into the core #1997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eberdosis/tiptap into feature/improve-link-detection
# Conflicts: # packages/core/package.json # yarn.lock
2 tasks
This was referenced Oct 8, 2021
This was referenced Oct 11, 2021
Closed
2 tasks
2 tasks
2 tasks
Hi there, is there any example how can we add old prosemirror-inputrules via the inputRules plugin exported by prosemirror-inputrules to the custom extension? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we are removing the
prosemirror-inputrules
dependency and adding a custom implementation into the core.Features
[\s\n]$
at the end of your input rule regex.prosemirror-inputrules
are exported by@tiptap/core
now. There are also some custom input rules and paste rules. You can use:markInputRule
nodeInputRule
textblockTypeInputRule
textInputRule
wrappingInputRule
markPasteRule
textPasteRule
Breaking changes
prosemirror-inputrules
. Because we provide these new feature, you can’t put input rules ofprosemirror-inputrules
intoaddInputRules()
in your extensions. If you still want to use these input rules you have to add them via theinputRules
plugin exported byprosemirror-inputrules
.