Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped content isn't parsed since input/paste rules are into core #2408

Closed
2 tasks done
Deckluhm opened this issue Jan 20, 2022 · 2 comments
Closed
2 tasks done

Dropped content isn't parsed since input/paste rules are into core #2408

Deckluhm opened this issue Jan 20, 2022 · 2 comments
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@Deckluhm
Copy link
Contributor

What’s the bug you are facing?

Drag & dropped content used to be correctly parsed by Tiptap but it's no longer the case (and I think it started happening after this PR: #1997).

Here is a short video where you can see me:

  1. Copy/pasting content from outside the document into it (it works as expected)
  2. Drag & dropping content from outside the document into it (markdown isn't parsed as it should be)
Peek.2022-01-20.10-59.mp4

How can we reproduce the bug on our side?

Easiest way to reproduce the issue is to:

  1. Go to the following page: https://tiptap.dev/examples/markdown-shortcuts
  2. Edit the title with markdown content like *Markdown* _content_
  3. Drag & drop title into the editor below

If you use the following versions of packages, it works as expected:

  • @tiptap/core version 2.0.0-beta.118 (issue started with 2.0.0-beta.119)
  • @tiptap/vue-3 version 2.0.0-beta.69
  • @tiptap/starter-kit version 2.0.0-beta.117

Can you provide a CodeSandbox?

https://codesandbox.io/s/cranky-mountain-zo2sw?file=/src/App.vue

What did you expect to happen?

Drag & dropped content should be treated like copy/pasted content (like it used to be).

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@Deckluhm Deckluhm added the Type: Bug The issue or pullrequest is related to a bug label Jan 20, 2022
@Deckluhm
Copy link
Contributor Author

Thank you for the quick fix, it works perfectly! 👌

@hanspagel
Copy link
Contributor

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants