Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to preserve marks from previous paragraph when toggling a listItem #3540

Closed
1 task
gethari opened this issue Dec 14, 2022 · 0 comments · Fixed by #3541
Closed
1 task

Ability to preserve marks from previous paragraph when toggling a listItem #3540

gethari opened this issue Dec 14, 2022 · 0 comments · Fixed by #3541
Labels
Type: Feature The issue or pullrequest is a new feature

Comments

@gethari
Copy link
Contributor

gethari commented Dec 14, 2022 •
edited
Loading

What problem are you facing?

We are in need of this functionality similar to msWord.

What’s the solution you would like to see?

We have started working on it, similar to hardbreak extension, we plan to use a keepMarks optional property on the splitList command when can use to preserve marks from the previous line. Hoping to raise a PR for this shortly.

What alternatives did you consider?

No response

Anything to add? (optional)

No response

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@gethari gethari added the Type: Feature The issue or pullrequest is a new feature label Dec 14, 2022
gethari added a commit to gethari/tiptap that referenced this issue Dec 14, 2022
@gethari
feat: ueberdosis#3540 Ability to preserve marks on lists
ad70224
@gethari gethari mentioned this issue Dec 15, 2022
Merged
bdbch pushed a commit that referenced this issue Feb 22, 2023
@gethari
feat: #3540 Ability to preserve marks on lists (#3541)
36bb1e1 
* feat: #3540 Ability to preserve marks on lists

* feat: preserveAttrs in list items

* `keepMarks` is working, but need help with `keepAttrs`

* fix: conflict

* avoid casting
aliasliao pushed a commit to aliasliao/tiptap that referenced this issue May 24, 2023
@gethari @aliasliao
feat: ueberdosis#3540 Ability to preserve marks on lists (ueberdosis#…
208d1bb 
…3541)

* feat: ueberdosis#3540 Ability to preserve marks on lists

* feat: preserveAttrs in list items

* `keepMarks` is working, but need help with `keepAttrs`

* fix: conflict

* avoid casting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature The issue or pullrequest is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #3540 Ability to preserve marks on lists gethari/tiptap
1 participant
@gethari