Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct reference for options.editorProps #1540

Merged

Conversation

robertvanhoesel
Copy link
Contributor

This change ensures that Editor.options.editorProps correctly references the ProseMirror View props this.view.props.It enables users to read and manipulate the props as expected. Additionally calls view.setProps(...) when editor.setOptions(...) is being called with editorProps so they can be set and updated through this method as well.

Includes tests, closes #1518

@robertvanhoesel
Copy link
Contributor Author

Any chance to get this reviewed and merged? @philippkuehn

@robertvanhoesel
Copy link
Contributor Author

@hanspagel @philippkuehn it would be a tad bit shameful community management if first time contributions stay untouched for a month. I would understand if you are too busy but a reply in any form would be appreciated.

@philippkuehn philippkuehn merged commit e6f67ca into ueberdosis:main Aug 9, 2021
@philippkuehn
Copy link
Contributor

Hey, sorry for that late response. Thanks for that PR. I made a few more changes after that: 80296aa

Please always use setOptions instead of mutating the options object directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't update editorProps after initialization.
2 participants