Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better types for event emitter #1959

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Conversation

HuiiBuh
Copy link
Contributor

@HuiiBuh HuiiBuh commented Sep 29, 2021

Fixes #1898

  • Made the EventEmitter generic to be able to specifically type the events
  • Created an interface EditorEvents for the event types
  • Updated the types in EditorOptions to use the types provided by the new EditorEvents interface

@philippkuehn philippkuehn merged commit 54e85fd into ueberdosis:main Sep 30, 2021
@philippkuehn
Copy link
Contributor

great! thank you very much! ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add better types for event emitter
2 participants