Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally delete full mention chip #3341

Merged
merged 7 commits into from
Apr 5, 2024

Conversation

Tommy-Sun
Copy link
Contributor

What

Made available the option to delete the full mention chip as well as the suggestion char.

Changes

  • Created an configuration flag for the mention extension called: deleteOnBackspace and defaulted it to false.

Why

Using Tiptap for a project our UX requirement was to remove the entire mention with only one backspace. This pull request also retains the original functionality by default.

@netlify
Copy link

netlify bot commented Oct 21, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit f4e85b0
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/65d6709f5d34580008101dab
😎 Deploy Preview https://deploy-preview-3341--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nVitius
Copy link
Contributor

nVitius commented Oct 24, 2022

@bdbch I worked w/ @Tommy-Sun to get this PR ready. Can you take a look and let us know if you have any comments?

@eruetsch
Copy link

eruetsch commented Oct 27, 2022

It would be really great if we could get this pull request merged! The functionality seems cool and useful @bdbch

@Tommy-Sun
Copy link
Contributor Author

Documentation added! @bdbch

@Tommy-Sun
Copy link
Contributor Author

Hi, just following up on this. Just need a review on the documentation I added! Would be great to use sooner rather than later. Thanks

@eruetsch
Copy link

yeah @bdbch please review the documentation so everything can be merged in and we can use this feature :)

bdbch
bdbch previously approved these changes Mar 3, 2023
Copy link
Contributor

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. @svenadlung what do you think?

@Tommy-Sun we also have a conflict there. I'd like to merge this. If you find time, could you resolve this issue?

@bdbch bdbch added this to the 2.0.0 Release milestone Mar 3, 2023
@bdbch bdbch modified the milestones: 2.0.0 Release, 2.1.0 Release Mar 27, 2023
@bdbch bdbch added Status: Review Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. labels Mar 29, 2023
@bdbch
Copy link
Contributor

bdbch commented Jun 25, 2023

@Tommy-Sun any updates?

@Tommy-Sun
Copy link
Contributor Author

@Tommy-Sun any updates?

Hi, not my best showing by any means but I finally came back around to this.

Caught up the branch and inputted a change renaming deleteOnBackspace to deleteTriggerWithBackspace

@Tommy-Sun
Copy link
Contributor Author

@bdbch This should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants