Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Build Process to Lerna + tsup & prepare for prosemirror-meta package #3555

Merged
merged 15 commits into from
Jan 25, 2023

Conversation

bdbch
Copy link
Member

@bdbch bdbch commented Dec 16, 2022

This PR changes our build process away from a custom rollup solution with package iterations to a simple tsup build. This includes:

  • tsup builds with one global tsconfig
  • individual package build tasks that extend the base tsconfig
    • this allows packages to have separate build processes without any super crazy configuration hacks
    • this is required for our new "prosemirror" meta package we're currently preparing

IMPORTANT

This PR is still WIP and needs to be heavily tested, specially the NPM publish and installation process with npm, yarn and pnpm.

TODO

  • Test package resolution with new bundles
  • Check Netlify demo build

@bdbch bdbch requested a review from svenadlung December 16, 2022 13:58
@bdbch bdbch self-assigned this Dec 16, 2022
@netlify
Copy link

netlify bot commented Dec 16, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 6152706
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/63cff68183b21700094ca819
😎 Deploy Preview https://deploy-preview-3555--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch bdbch mentioned this pull request Dec 16, 2022
7 tasks
@bdbch bdbch marked this pull request as draft December 16, 2022 15:30
@bdbch bdbch marked this pull request as ready for review January 20, 2023 11:44
demos/package.json Show resolved Hide resolved
demos/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/extension-bubble-menu/package.json Outdated Show resolved Hide resolved
packages/core/package.json Outdated Show resolved Hide resolved
packages/core/package.json Outdated Show resolved Hide resolved
packages/vue-3/tsconfig.json Outdated Show resolved Hide resolved
@bdbch bdbch requested a review from svenadlung January 20, 2023 14:24
svenadlung
svenadlung previously approved these changes Jan 20, 2023
@bdbch bdbch merged commit e46f8e3 into main Jan 25, 2023
@bdbch bdbch deleted the build-update branch January 25, 2023 09:19
aliasliao pushed a commit to aliasliao/tiptap that referenced this pull request May 24, 2023
…ackage (ueberdosis#3555)

* chore:(core): migrate to tsup

* chore: migrate blockquote and bold to tsup

* chore: migrated bubble-menu and bullet-list to tsup

* chore: migrated more packages to tsup

* chore: migrate code and character extensions to tsup

* chore: update package.json to simplify build for all packages

* chore: move all packages to tsup as a build process

* chore: change ci build task

* chore: clean up and fix issues related to new build

* fix: fix demo build

* fix: fix demo build

* fix: fix tsconfig files to reference only one source

* fix: fix minor ts issues
andrewlu0 pushed a commit to trybaseplate/tiptap that referenced this pull request Oct 20, 2023
…ackage (ueberdosis#3555)

* chore:(core): migrate to tsup

* chore: migrate blockquote and bold to tsup

* chore: migrated bubble-menu and bullet-list to tsup

* chore: migrated more packages to tsup

* chore: migrate code and character extensions to tsup

* chore: update package.json to simplify build for all packages

* chore: move all packages to tsup as a build process

* chore: change ci build task

* chore: clean up and fix issues related to new build

* fix: fix demo build

* fix: fix demo build

* fix: fix tsconfig files to reference only one source

* fix: fix minor ts issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants