Retain existing config when calling configure on Marks and Extensions

[nholden]

Currently, when you call .configure() on a Mark or Extension, the Mark or Extension that's returned doesn't retain the config from the original.

This is a problem for StarterKit. When Code is added to an editor added as a standalone extension, an inline code block is exitable. When added as part of StarterKit, an inline code block is not exitable because StarterKit calls Code.configure(), blowing away the default config.

This PR ensures that when you call .configure() on a Mark or Extension, the Mark or Extension that's returned retains the config from the original.

closes #3813

[netlify]

✅ Deploy Preview for tiptap-embed ready!

Name	Link
🔨 Latest commit	c0ec0c2
🔍 Latest deploy log	https://app.netlify.com/sites/tiptap-embed/deploys/6403829193be470008344a71
😎 Deploy Preview	https://deploy-preview-3822--tiptap-embed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[bdbch]

Good find. Thanks, LGTM! @svenadlung ?

[fleon]

@bdbch Can we get this merged? Looks pretty straightforward. 😄

[svenadlung]

@bdbch Looks good to me. Feel free to merge.

[huangmb]

I think the main problem is ExtensionManager，extension.type === 'mark' && extension.config.exitable not call callOrReturn(getExtensionField(extension,'exitable'))
5fed0f2#diff-34ea668dac19f1717ece64fd0716f0709a69da5401e5615aa8de1cd801c9f30c

[huangmb]

my temporary solution is

addProseMirrorPlugins() {
        const extensions = this.options.extensions || [];
        return extensions.filter(extension => extension.type === 'mark')
            .map(extension => {
                const editor = this.editor
                const context = {
                    name: extension.name,
                    options: extension.options,
                    storage: extension.storage,
                    editor,
                }
                if (extension.config.exitable) {
                    // ExtensionManager已经正常处理了,跳过
                    return null
                }
                const exitable = callOrReturn(getExtensionField(extension, 'exitable', context))
                if (exitable) {
                    return keymap({
                        ArrowRight: () => Mark.handleExit({editor, mark: extension})
                    })
                }
                return null
            })
            .filter(plugin=>plugin)
    }

if tiptap core fix this bug, i will remove this extension

[bdbch]

Sorry but I had to revert this PR as it was breaking a lot of the core functionality. It's included in v2.1.0-rc.2 if you want to test it yourself.

Basically this.config will be { name: 'mark', defaultOptions: {} } by default which means type names won't be correct anymore and the defaultOptions warning will be appear by default.

Could you check into this again @nholden ?

[nholden]

Good catch, @bdbch! I took another stab at this in #3998.