fix: clear nodes when cursor at start of empty isolating parent #3943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This fix will solve the issue that when a cursor is inside an isolating node and the isolating node is empty, the nodes inside are not cleared similar to how they are cleared on the document.
How did you accomplish your changes
Inside the
keymap.ts
we also check for the current textNodes parent (or direct parent if it is not a textNode) and if said parent isisolating
. If we are inside an isolating node, we use the relative parentOffset to check that we're at the start of a node.How have you tested your changes
How can we verify your changes
Checklist
Related issues
No related issues