fix(bubble-menu): fix debounce not working with collab #3956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
svenadlung
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR should close #3953 via checking if changes were made to the doc/selection and exiting before clearing the callback timeout.
How did you accomplish your changes
Add a simple check before clearing debounced timeouts if the doc was changed.
How have you tested your changes
I created a local demo with collab/cursors and a bubble menu and tested to create selections on both clients - worked fine, also with collab and collab cursors. the bubble menu delay was also working fine.
How can we verify your changes
Follow the same steps as above
Remarks
The additional file changes were made to:
Checklist
Related issues