Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component names in Vue 3 devtools #3970

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

segevfiner
Copy link
Contributor

Please describe your changes

Fix component names in Vue 3 devtools

How did you accomplish your changes

Propogate __name, __file in VueNodeViewRenderer, and add name to NodeViewContent & NodeViewWrapper.

How have you tested your changes

Ran npm run start and checked pages that show NodeViews with Vue 3

How can we verify your changes

Do the same as I did above. With the Vue devtools installed in the browser.

Remarks

[add any additional remarks here]

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

Fixes #3965

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 74cf18e
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/643eab37b271c40008dfd01b
😎 Deploy Preview https://deploy-preview-3970--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

@bdbch bdbch merged commit 87b83e3 into ueberdosis:develop Jul 7, 2023
@segevfiner segevfiner deleted the vue3-devtools branch July 7, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @vue/devtools shows NodeView components as "Anonymous Component"
2 participants