Docs/installation cdn #4045
Merged
Docs/installation cdn #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 3 examples of CDN usage.
Uncommented CDN line
removed Skypack -- not reliable in testing with Codepen.
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@RicoTrevisan Thank you so much for your contribution. The ESM.RUN sandbox seems to have an error I think. It shows I am wondering how they handle peer dependencies like |
removed esm.run. I couldn't solve the issue.
|
Hey @svenadlung , thanks for catching that. I've tried to get to the root-cause of that issue, but failed. Let's leave just the esm.sh implementation there. Hopefully this can be of help to someone. Thanks for letting me contribute. |
|
hi, i am the maintainer of esm.sh, glad to see this PR. if you have any problem with esm.sh please just tell me, i am happy to fix/improve. thanks! |
bdbch
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
How did you accomplish your changes
I've built examples of each one of them in Codepen:
How have you tested your changes
With the Codepen examples.
How can we verify your changes
Just open the links to the different Codepens to make sure they work.
Remarks
I'm a rookie contributor, I'm trying to learn, but not sure if I'm doing it correctly. If something is missing or unclear, please let me know -- I'd love to learn.
Checklist
Related issues
[add a link to the related issues here]