-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/wrapper class #4068
Feature/wrapper class #4068
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎 finally we're starting a bit of bragging!!!
Should this be considered a breaking change? Not sure if it's documented anywhere but I'm thinking so, because |
@rfgamaral the .ProseMirror classes are still there, instead of |
@janthurau Thanks for clarifying. |
For things like styling Tiptap it's a bit inconsistent to use The more specific classes like |
IMO, styling should be flexible enough where you can use whatever tooling your project requires without explicitly targetting global classes such as |
@rfgamaral You are right! I mean simpler setups like the ones mentioned here: https://github.com/ueberdosis/tiptap/blob/v2.0.3/docs/guide/styling.md#option-1-style-the-plain-html |
Please describe your changes
We can be proud of what we have built. So let's show this to all devs in the world! I prepend the class name
tiptap
to the editor element 🎉How did you accomplish your changes
I added a new method in the Editor class to prepend
tiptap
in the list of classes. I have updated the docs and demos.How have you tested your changes
I ran the demos and looked for the class name in the wrapper element. The tests are also working as expected.
How can we verify your changes
You can check the demos and search for the new class name.
Checklist