Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not use window.open for links in readonly mode #4073

Merged
merged 2 commits into from
Jul 7, 2023
Merged

fix: do not use window.open for links in readonly mode #4073

merged 2 commits into from
Jul 7, 2023

Commits on May 25, 2023

  1. fix: do not use window.open for links in readonly mode 

    When `contenteditable` is `true`, the browser doesn't allow
direct link opens on clicking the `a` element. This is why we
need to call `window.open` to open our links.

However, when `contenteditable` is `false`, the default
browser mechanism for opening links works and there is no
need for using `window.open`.
    @thecodrr
    thecodrr committed May 25, 2023
    Configuration menu
    Copy the full SHA
    8bb32e9 View commit details
    Browse the repository at this point in the history

  2. fix: linting errors

    @thecodrr
    thecodrr committed May 25, 2023
    Configuration menu
    Copy the full SHA
    9c84cc0 View commit details
    Browse the repository at this point in the history