Rel cannot be set #4112
Merged
Rel cannot be set #4112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the addAttributes entry, passing the rel attribute doesn't work (tested in 2.0.3)
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bdbch
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the addAttributes entry, passing the rel attribute doesn't work (tested in 2.0.3)
Please describe your changes
Add the rel entry
How did you accomplish your changes
Seeing that my rel attribute wasn't set, i tested with this entry, and it works
How have you tested your changes
Tested locally on 2.0.3
How can we verify your changes
Simply try to pass a rel attribute to setLink, it doesn't work
Checklist