-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom selection builders #4128
Add support for custom selection builders #4128
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@bdbch Can you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one! could you add the new selectionRender
option to the docs too? @benglewis
@bdbch I've added the property to the documentation. Hopefully I understood how to do it correctly. |
@bdbch please, merge and release this request 🙇🏻♂️ |
@bdbch Any updates regarding this merge? 🙏 |
Hi @svenadlung @bdbch , Is there any chance that you can please review and merge this PR? 🙏 |
Please describe your changes
Add support for custom selection builders.
How did you accomplish your changes
Added new field to the extension options, type and passing along parameter to the
y-prosemirror
extension. Passing by default the existing default value to avoid breaking anything.How have you tested your changes
Ran the existing collaboration demo locally with the changes applied. Verified that the cursor and selection is shown correctly.
How can we verify your changes
You can clone code and check that the collaboration cursor and selection is not broken.
Remarks
N/A
Checklist