Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add missing editor getters #4150

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Documentation: Add missing editor getters #4150

merged 1 commit into from
Jun 25, 2023

Conversation

muttenzer
Copy link
Contributor

@muttenzer muttenzer commented Jun 23, 2023

Please describe your changes

I added the following editor getters to the docs, since they are currently missing and only discoverable through autocompletion: isFocused, isDestroyed, isCapturingTransaction.

How did you accomplish your changes

How have you tested your changes

How can we verify your changes

You can check the docs at /api/editor to verify my changes.

Remarks

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

@netlify
Copy link

netlify bot commented Jun 23, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 13060ea
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/6495823a41722200087db72e
😎 Deploy Preview https://deploy-preview-4150--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙏

@bdbch bdbch merged commit b618336 into ueberdosis:develop Jun 25, 2023
4 checks passed
@muttenzer muttenzer deleted the docs/editor-getters branch June 25, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants